Release-1.19.1 - Revert #3122 #3157
Merged
+23
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #3122 for release of 1.19.1 which is in progress.
An issue with VPC CNI 1.19.1 was caught in internal CI.
Cluster was created with IPV6 Address always assigned - https://github.com/aws/aws-k8s-tester/blob/c6bee21d2bbc2756f4a91bb5bc68495d2533b323/kubetest2/internal/deployers/eksapi/templates/infra.yaml#L289
IPAMD Initialization failed with this log message.
This is due to change we brought in
Fix issues with handling unmanaged ENIs with IPv6 only - #3122
Previously we assumed the ENI (primary ENI) always will have an IPV4 and went with getting the IPv4 address. Primary ENI will always have an IPV4 address. However, when #3122 was introduced, we are checking ipv4Available explicitly. The way in which the ipv4 or ipv6 is checked in based on the value of IMDS metadata on MAC, dependent on the order in which IMDS returned the value due to using a break condition introduced here - https://github.com/aws/amazon-vpc-cni-k8s/pull/3047/files . So, when both
IPv6
andIPv4
were assigned on interface, it tried to pick upIPv6
address even when the cluster was not IPV6.Fix in the master is in review here - #3156