utils prometheusmetrics: convert gauges to counters #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshehbaj
force-pushed
the
shehbaj/addipcnt-gauge-bug
branch
from
193aec9 to
5d14bce
Compare
dshehbaj
changed the title
dshehbaj
force-pushed
the
shehbaj/addipcnt-gauge-bug
branch
2 times, most recently
from
e7db380 to
f447ce6
Compare
jaydeokar
reviewed
Oct 29, 2024
dshehbaj
force-pushed
the
shehbaj/addipcnt-gauge-bug
branch
from
f447ce6 to
8d6eee5
Compare
ROunofF
pushed a commit
to ROunofF/amazon-vpc-cni-k8s
that referenced
this pull request
Nov 22, 2024
orsenthil
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit d57c443.
orsenthil
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit d57c443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
Which issue does this PR fix?:
#3031
What does this PR do / Why do we need it?:
Bug fix
Testing done on this change:
Added unit tests confirming the behavior of the counters.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.