Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo controlled build go version #2831

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Repo controlled build go version #2831

merged 1 commit into from
Mar 5, 2024

Conversation

xdu31
Copy link
Member

@xdu31 xdu31 commented Mar 4, 2024

What type of PR is this? build system change

Which issue does this PR fix?:

What does this PR do / Why do we need it?:
Repo controlled Go version, follow kubernetes/enhancements#3744 to make amazon-vpc-cni-k8s to stay on supported Go versions.

This PR follows kubernetes/kubernetes#114660 and kubernetes/kubernetes#115377 for repo-controlled go version to use in CI.

Testing done on this change:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades? Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xdu31 xdu31 requested a review from a team as a code owner March 4, 2024 22:12
jaydeokar
jaydeokar previously approved these changes Mar 4, 2024
Copy link
Contributor

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@xdu31 xdu31 merged commit 5aa2e90 into aws:master Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants