Revert #2744 to prevent livelock when attempting to increase datastore pool #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Feb 23, 2024
jdn5126
force-pushed
the
high_cpu
branch
3 times, most recently
from
ec81f29 to
2e74b1e
Compare
orsenthil
reviewed
Feb 28, 2024
jdn5126
changed the title
|
LGTM too. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#2807
What does this PR do / Why do we need it:
This PR fixes a livelock condition that was reported in #2807. When the datastore pool is too low, we try to aggressively scale up to the desired state, hence the for loop. Under certain conditions, the datastore pool could return "too low" for a prolonged period of time (or indefinitely).
The change here is to revert #2744 so that only one scale up attempt happens during each iteration of the activity loop.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Ran all integration tests to ensure that they passed.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.