Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni-metrics-helper add podAnnotation value #2748

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

prysmakou
Copy link
Contributor

@prysmakou prysmakou commented Jan 10, 2024

What type of PR is this?

feature
cni-metrics-helper add deployment.podAnnotation value

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:
Allows to add arbitrary annotations to pods (eg DataDog requires specific annotation to scrap Prometheus metrics)

Testing done on this change:
manual deploy

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:
It changes the deployment/daemonset

Does this PR introduce any user-facing change?:
It introduces a new parameter in cni-metrics-helper helm chart (with a default value {} )


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@prysmakou prysmakou marked this pull request as ready for review January 10, 2024 15:06
@prysmakou prysmakou requested a review from a team as a code owner January 10, 2024 15:06
@jdn5126
Copy link
Contributor

jdn5126 commented Jan 10, 2024

Thanks for the contribution @prysmakou! Let's follow the example set by the aws-vpc-cni chart: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/aws-vpc-cni/values.yaml#L117 and https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/aws-vpc-cni/templates/daemonset.yaml#L24

Also, can you update the title and description to be cni instead of csi?

@prysmakou prysmakou force-pushed the feat/helm_chart_pod_annotations branch from bbe3a9c to 7d89202 Compare January 11, 2024 06:22
@prysmakou prysmakou changed the title csi-metrics-helper add deployment.podAnnotation value cni-metrics-helper add deployment.podAnnotation value Jan 11, 2024
charts/cni-metrics-helper/Chart.yaml Outdated Show resolved Hide resolved
charts/cni-metrics-helper/values.yaml Outdated Show resolved Hide resolved
@prysmakou prysmakou force-pushed the feat/helm_chart_pod_annotations branch from cd858ba to ead633f Compare January 11, 2024 18:48
@prysmakou prysmakou requested a review from jdn5126 January 12, 2024 06:10
@prysmakou prysmakou changed the title cni-metrics-helper add deployment.podAnnotation value cni-metrics-helper add podAnnotation value Jan 12, 2024
@jdn5126 jdn5126 force-pushed the feat/helm_chart_pod_annotations branch from 3f9956b to dc91820 Compare January 17, 2024 18:56
@jdn5126 jdn5126 merged commit bcd8f3e into aws:master Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants