Use unix.RT_TABLE_MAIN for main routing table number
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes to use `unix.RT_TABLE_MAIN` from fixed value `254`. Since Go's library prepares the variable for each architecture, it should be used for the portability. (All architectures uses `0xfe(=254)`, though.) Also, this patch contains unit test for `UpdateRuleListBySrc()`.
mogren
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch changes to use
unix.RT_TABLE_MAINfrom fixed value254.Since Go's library prepares the variable for each architecture, it
should be used for the portability. (All architectures uses
0xfe(=254), though.)Also, this patch contains unit test for
UpdateRuleListBySrc().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.