Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swicth grpc deprecated method to new method #2665

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

Icarus9913
Copy link
Contributor

The grpc method grpc.WithInsecure() is already deprecated. Use grpc.WithTransportCredentials() and insecure.NewCredentials()

Signed-off-by: Icarus9913 icaruswu66@qq.com

What type of PR is this?
cleanup

Which issue does this PR fix:
none

What does this PR do / Why do we need it:
switch the k8s sdk deprecated method to new method

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
none

Testing done on this change:

Will this PR introduce any new dependencies?:
none

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
none

Does this change require updates to the CNI daemonset config files to work?:
none

Does this PR introduce any user-facing change?:

none

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Icarus9913 Icarus9913 requested a review from a team as a code owner November 15, 2023 14:53
Copy link
Contributor

@jdn5126 jdn5126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@jdn5126 jdn5126 merged commit dcc2856 into aws:master Nov 15, 2023
6 checks passed
@Icarus9913 Icarus9913 deleted the grpc-sdk branch November 23, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants