Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-limits #2634

Merged
merged 1 commit into from
Oct 30, 2023
Merged

generate-limits #2634

merged 1 commit into from
Oct 30, 2023

Conversation

dougbyrne
Copy link
Contributor

What type of PR is this?
cleanup

Which issue does this PR fix:
n/a

What does this PR do / Why do we need it:
Ran make generate-limits to adds limits/resources for new instance types

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
n/a

Testing done on this change:

none

Will this PR introduce any new dependencies?:

no

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
no

Does this change require updates to the CNI daemonset config files to work?:

no

Does this PR introduce any user-facing change?:

Updated resources for new instance types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougbyrne dougbyrne requested a review from a team as a code owner October 30, 2023 14:09
@dougbyrne dougbyrne changed the title genate-limits generate-limits Oct 30, 2023
@dougbyrne dougbyrne force-pushed the generate-limits-20231030 branch from 1eaa824 to 8d15b2b Compare October 30, 2023 14:10
@jdn5126
Copy link
Contributor

jdn5126 commented Oct 30, 2023

Thanks @dougbyrne! Can you check that your misc/eni-max-pods.txt changes match what is in https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt?

@jdn5126
Copy link
Contributor

jdn5126 commented Oct 30, 2023

Otherwise we can create a PR to update the AMI repo as well

@dougbyrne
Copy link
Contributor Author

There are some differences, this includes some metal types not in the file you linked.

c7i.metal-24xl 737
c7i.metal-48xl 737
m7i.metal-24xl 737
m7i.metal-48xl 737
r7i.metal-24xl 737
r7i.metal-48xl 737

@jdn5126
Copy link
Contributor

jdn5126 commented Oct 30, 2023

There are some differences, this includes some metal types not in the file you linked.

c7i.metal-24xl 737
c7i.metal-48xl 737
m7i.metal-24xl 737
m7i.metal-48xl 737
r7i.metal-24xl 737
r7i.metal-48xl 737

Got it, do you mind creating a PR for that repo as well? You should be able to just copy misc/eni-max-pods.txt over the existing one. Once these two are in sync, we can merge.

@dougbyrne
Copy link
Contributor Author

Added corresponding PR awslabs/amazon-eks-ami#1496

@jdn5126 jdn5126 merged commit 6aff2e0 into aws:master Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants