Upgrade CNI spec from 0.4.0 to 1.0.0 #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
force-pushed
the
cnispec
branch
3 times, most recently
from
9cbe9a3 to
eb4b641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
spec upgrade
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR updates the container networking spec used by the VPC CNI from 0.4.0 to 1.0.0. This is needed to stay up to date with the latest
containternetworkingpackage.Note that
containernetworking/cni v1.1.2provides libraries such that spec 0.4.0 and 1.0.0 are fully forward and backward compatible. There are co changes in this PR related to the new spec other than the CNI version.Also note that this PR will require a minor version update, i.e.
v1.16.x. This PR also introduces a requirement that the EKS version be at least 1.24.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that pods created with image using 0.4.0 spec can be properly loaded and deleted by image using 1.0.0 spec (and vice versa).
Manually verified that all integration tests pass.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
Yes, this PR makes VPC CNI compatible only with EKS 1.24+.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.