-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus metrics scraping from CNI metrics helper #2603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change overall LGTM
Let's wait on merge..I see an issue here. |
bb53cd4
to
574675a
Compare
Issue with aggregation fixed.. |
2bf230a
to
140c6be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall, just a few nits. Can you also rebase to latest master?
7ac8bd6
to
c62c4ab
Compare
c62c4ab
to
5a29a2f
Compare
What type of PR is this?
Feature
Which issue does this PR fix:
Fixes #2071
What does this PR do / Why do we need it:
Reopening #2192 and some additional refactoring.
CNI metrics helper merges all the metrics from aws-nodes and aggregates the metrics to send for CW. With this PR the aggregated data is sent to Prometheus when "USE_PROMETHEUS" is set. As part of initial enhancement only Prometheus type GAUGE is streamed for prometheus. Future enhancements will be made for other types of metrics.
This will include -
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.