Increase datastore pool at startup #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
commented
Apr 19, 2023
This was referenced Apr 19, 2023
jayanthvn
reviewed
Apr 24, 2023
jayanthvn
reviewed
Apr 24, 2023
jayanthvn
reviewed
Apr 24, 2023
jdn5126
force-pushed
the
cn_opt
branch
3 times, most recently
from
b96ef96 to
ea99b53
Compare
jdn5126
force-pushed
the
cn_opt
branch
5 times, most recently
from
4b7ad82 to
08b3b42
Compare
jdn5126
force-pushed
the
cn_opt
branch
3 times, most recently
from
1122fce to
86b7843
Compare
jayanthvn
reviewed
May 11, 2023
| timeSinceLast := time.Since(c.lastNodeIPPoolAction) | ||
| if timeSinceLast <= interval { | ||
| // Make an exception if node needs a trunk ENI and one is not currently attached. |
There was a problem hiding this comment.
One callout for this change is that, if trunk ENI fails to attach for any VPC RC issues then aws-node keeps running the reconciliation..maybe as an enhancement we should make it like a backoff retry in cases of SGPP..
jayanthvn
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#1724
What does this PR do / Why do we need it:
This PR fixes two issues:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that when ENIConfigs are missing, node remains in "Not Ready" state as IPAMD returns error. Also verified that when ENIConfigs are present, ENIs are attached during node initialization.
Verified that CNI integration release tests pass. Scheduling GitHub runner as well.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.