Make all the aws vpc cni environmental variables case insensitive #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
suggested changes
Mar 29, 2023
There was a problem hiding this comment.
This helps environment variables read in cmd/aws-vpc-cni/main.go, but we need to be more thorough and do case-insensitive compare everywhere a boolean environment variable is accessed.
Also, this same function is in cmd/aws-vpc-cni-init/main.go
You'll need to go through each "Boolean as a String" environment variable in https://github.com/aws/amazon-vpc-cni-k8s#cni-configuration-variables and ensure that everywhere it is read in the code does a case-insensitive compare.
jdn5126
suggested changes
Apr 18, 2023
jdn5126
suggested changes
Apr 20, 2023
jdn5126
suggested changes
Apr 21, 2023
jdn5126
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Just a few more nits and then this should be good to go. @jerryhe1999 can you also rebase and squash this into one commit?
made environmental flags managed by aws-vpc-cni-init/main.go case insensitive refactor getEnv function in cmd/aws-vpc-cni and cmd/aws-vpc-cni-init fixed logic issue and added unit tests for utils package fixed import function name with Capital initial log the error message instead of return it removed unnecessary log
jerryhe1999
force-pushed
the
feature-flag-insensitive
branch
from
2ac819f to
89ac30d
Compare
jdn5126
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#2311
What does this PR do / Why do we need it:
Originally, we have several aws-vpc-cni environmental variables with the type Boolean as a String which against good coding standards. Having case insensitive values for Boolean can avoid users meet situation that spend 2+ weeks to figure out the case sensitivity cause the problem.
Testing done on this change:
Manually tested the code change in testing cluster with setting environmental variables in case insensitivity. Both unit tests and integration tests passed
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.