Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting SourceDestCheck to false in AllocENI #233

Closed
wants to merge 1 commit into from

Conversation

nickdgriffin
Copy link

Issue #, if available:
#231

Description of changes:
This disables the SourceDestCheck on the ENIs that are created by AllocENI so that packets are not dropped in the case where a NodePort service's backend pods have IPs allocated from a secondary interface. The NodePort traffic enters on eth0 and is then dropped by the secondary interface (e.g. eth1) when the source/destination check is true, as per the default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren
Copy link
Contributor

mogren commented Aug 2, 2019

@nickdgriffin, is this still an issue?

@mogren mogren closed this Sep 27, 2019
@infinitydon
Copy link

Currently we have a use-case for this (having the option to enable/disable SourceDestCheck):

  • As part of network connectivity requirement for some Telco cloud native functions.
  • Aid debugging process but not of having to do this manually for every worker node ENIs, this will make it easier to automate enabling/disabling SourceDestCheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants