Added EC2 instance types M6in, M6idn, R6in, and R6idn to eni-max-pods… #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. But there is a script to generate the file - You can ref to this - #2092. Secondly if not already done, then we would also need the changes cherry-picked to https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt. Please ref - awslabs/amazon-eks-ami#1033 |
|
Thanks for the help! I missed the script. I'll make the necessary changes and re-submit. |
…n-vpc-cni-k8s into add-EC2-instance-types merge push
|
@nickmancari looks like there are no changes here. Did an update go wrong? |
|
Closing as this is covered by #2235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….txt
What type of PR is this?
documentation
Which issue does this PR fix:
#2206
What does this PR do / Why do we need it:
Update txt file
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.