Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-go and k8s packages #2204

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jaydeokar
Copy link
Contributor

What type of PR is this?
cleanup

Which issue does this PR fix:
#2195

What does this PR do / Why do we need it:
Update package versions for client-go and other k8s packages. Also upgrades packages which has security vulnerabilities

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A

Testing done on this change:
Yes, tested cni, ipamd and metrics-helper

Automation added to e2e:
N/A

Will this PR introduce any new dependencies?:
N/A

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A

Does this change require updates to the CNI daemonset config files to work?:
N/A

Does this PR introduce any user-facing change?:
N/A

Update client-go and other k8s package versions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaydeokar jaydeokar requested a review from a team as a code owner January 12, 2023 18:03
Copy link
Contributor

@jdn5126 jdn5126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks! Let's call out the github.com/containernetworking/cni/pkg/types change in the PR description and link to the upstream documentation. Let's also add a longer form release note.

cmd/egress-v4-cni-plugin/cni.go Outdated Show resolved Hide resolved
@jdn5126
Copy link
Contributor

jdn5126 commented Jan 12, 2023

@jaydeokar please kick off a manual integration test run against this PR when you are ready

@jaydeokar jaydeokar force-pushed the update_package_versions branch from f17b081 to 2284f76 Compare January 12, 2023 18:55
@jayanthvn
Copy link
Contributor

Can you pl check the UT failures?

@jaydeokar jaydeokar force-pushed the update_package_versions branch 3 times, most recently from 046308e to 818b5e3 Compare January 20, 2023 01:31
jdn5126
jdn5126 previously approved these changes Jan 23, 2023
go.mod Show resolved Hide resolved
@jdn5126 jdn5126 force-pushed the update_package_versions branch from a458425 to 8d5fb29 Compare January 23, 2023 23:07
@jdn5126 jdn5126 force-pushed the update_package_versions branch from 8d5fb29 to c64bfee Compare January 23, 2023 23:34
@jdn5126 jdn5126 force-pushed the update_package_versions branch from c64bfee to 307cebc Compare January 24, 2023 00:13
@jdn5126 jdn5126 merged commit 2001937 into aws:master Jan 24, 2023
@jayanthvn jayanthvn added this to the v1.13.0 milestone Jan 28, 2023
@jdn5126 jdn5126 mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants