v1.12 Helm chart changes and release manifests #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM. Can you also update the README in the root directory to reflect the dockershim removal? The "Container Runtime" section, that is |
jayanthvn
reviewed
Oct 27, 2022
There was a problem hiding this comment.
lgtm but we need to update the readme - https://github.com/aws/amazon-vpc-cni-k8s#container-runtime
orsenthil
previously approved these changes
Oct 27, 2022
|
updated the readme about container runtime :D |
|
A post merge comment. Can we prevent installation of these in < EKS 1.24 cluster. |
jdn5126
pushed a commit
to jdn5126/amazon-vpc-cni-k8s
that referenced
this pull request
Oct 28, 2022
* v1.12 Helm chart changes and release manifests * update readme for container runtime * update readme for container runtime
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
release
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR adds the release manifests and helm changes for v1.12
The helm chart version was bumped to v1.2.0 since we no longer have CRI mounts since CNI v1.12
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Manually tested canary tests with generated YAML.
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Yes. This helm chart is only compatible with CNI version >= v1.12
Does this change require updates to the CNI daemonset config files to work?:
Yes, the CNI's CRI mount is removed. Since CNI v1.12, we switched to use state file instead of rely on CRI mount.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.