Configure MTU of ENI and veths to 9001 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,8 @@ const ( | |||
| // - kube-proxy uses 0x0000c000 | |||
| // - Calico uses 0xffff0000. | |||
| defaultConnmark = 0x80 | |||
|
|
|||
| ethernetMTU = 9001 | |||
There was a problem hiding this comment.
Can you add a comment here to indicate that 9001 also need to be defined in driver.go?
There was a problem hiding this comment.
Updated to add comments where MTU is defined.
| @@ -44,6 +44,7 @@ const ( | |||
| testeniIP = "10.10.10.20" | |||
| testeniMAC = "01:23:45:67:89:ab" | |||
| testeniSubnet = "10.10.0.0/16" | |||
| testMTU = 9001 | |||
There was a problem hiding this comment.
same here, can u also add a comment that 9001 needs to be defined in network.go. thanks
There was a problem hiding this comment.
Updated to add comments where MTU is defined.
* Add LinkSetMTU wrapper and mocks * Add call to ENI setup and network test * Change hardcoded veth MTU to 9001
liwenwu-amazon
approved these changes
Oct 24, 2018
|
@gtaylor yes, that's how I understand this issue. Only the primary, auto-created NIC gets jumbo frames by default. This code makes it so all NICs get jumbo frames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#167
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.