Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch eniconfig CRD if cni is not configured to use pod config #192

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

liwenwu-amazon
Copy link
Contributor

Issue #188 , if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liwenwu-amazon liwenwu-amazon merged commit 7cfcd20 into aws:master Oct 4, 2018
@dcarley
Copy link

dcarley commented Oct 4, 2018

Will there be a 1.2.1 patch release for this?

@aleerizw-zz
Copy link

Are you guys planning a new release? We can't really use the 1.2 version without this change.

@dcarley
Copy link

dcarley commented Oct 9, 2018

We can't really use the 1.2 version without this change.

If it helps, it did work for me when applying the complete config including the CRD: https://github.com/aws/amazon-vpc-cni-k8s/blob/v1.2.0/config/v1.2/aws-k8s-cni.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants