-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support new SGPP standard mode #1907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@M00nF1sh - Can you please run "make format"? |
M00nF1sh
force-pushed
the
sgpp_enhance
branch
2 times, most recently
from
March 7, 2022 20:38
a8c14e8
to
0be6f77
Compare
cgchinmay
reviewed
Mar 8, 2022
cgchinmay
reviewed
Mar 8, 2022
cgchinmay
reviewed
Mar 8, 2022
cgchinmay
reviewed
Mar 8, 2022
M00nF1sh
force-pushed
the
sgpp_enhance
branch
5 times, most recently
from
March 9, 2022 19:25
af14a3d
to
c42c8f4
Compare
achevuru
reviewed
Mar 9, 2022
achevuru
reviewed
Mar 9, 2022
achevuru
reviewed
Mar 9, 2022
achevuru
reviewed
Mar 10, 2022
achevuru
reviewed
Mar 10, 2022
achevuru
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
achevuru
reviewed
Mar 11, 2022
jayanthvn
reviewed
Mar 11, 2022
M00nF1sh
force-pushed
the
sgpp_enhance
branch
7 times, most recently
from
March 22, 2022 23:20
70156a5
to
8e6c69c
Compare
achevuru
approved these changes
Mar 28, 2022
jayanthvn
approved these changes
Mar 30, 2022
@M00nF1sh The description contains conflicting statements. I assume this one is wrong:
I assume default is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
cleanup
Which issue does this PR fix:
This PR supports calico network policy & NodeLocalDNS for Pods with SecurityGroup with a new traffic mode.
What does this PR do / Why do we need it:
POD_SECURITY_GROUP_ENFORCING_MODE
, which decides the traffic mode "security group for pods" feature.The possible settings of
POD_SECURITY_GROUP_ENFORCING_MODE
are:strict
: all inbound/outbound traffic from pod with security group will be enforced by security group rules.standard
: the traffic of pod with security group behaves same as pods without security group, except that each pod occupies dedicated ENIIf an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
driver.go
gomock.any
Automation added to e2e:
Will this PR introduce any new dependencies?:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
No, the default value of "POD_SECURITY_GROUP_ENFORCING_MODE" if not set is "standard".
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.