Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated go version in go.mod #1832

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Updated go version in go.mod #1832

merged 4 commits into from
Jan 31, 2022

Conversation

cgchinmay
Copy link
Contributor

What type of PR is this?
feature

Which issue does this PR fix:
Update go version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cgchinmay cgchinmay marked this pull request as ready for review January 31, 2022 11:26
@cgchinmay cgchinmay requested a review from a team as a code owner January 31, 2022 11:26
@jayanthvn
Copy link
Contributor

Even arm and x86 builds look fine.

@cgchinmay cgchinmay merged commit fae67b2 into aws:master Jan 31, 2022
orsenthil
orsenthil approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question if the upgrade golang, will need any integration testing before release.

I think, Integration testing will be safe, since we are upgrading go.mod dependencies along with the runtime.

@cgchinmay cgchinmay mentioned this pull request Jan 31, 2022
Merged
@jayanthvn
Copy link
Contributor

jayanthvn commented Jan 31, 2022 •
edited
Loading

Yeah agreed. We should run the integration test suite before release.

@cgchinmay
Copy link
Contributor Author

I had a question if the upgrade golang, will need any integration testing before release.

I think, Integration testing will be safe, since we are upgrading go.mod dependencies along with the runtime.

Integration and e2e tests did pass

@orsenthil
Copy link
Member

Integration and e2e tests did pass

Nice. You could link to the success of the Integration test link in the SIM tickets, just for future reference.
VPC resource controller integration tests could be included too.

Thank you, @cgchinmay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayanthvn jayanthvn jayanthvn approved these changes

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgchinmay @jayanthvn @orsenthil