Support for no_manage=false #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M00nF1sh
approved these changes
Sep 11, 2021
|
Yes, I am working on the UTs PR. Will send a follow up tonight. |
jayanthvn
added a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Sep 11, 2021
* Support for no_manage=false * pr comments
jayanthvn
added a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
Which issue does this PR fix:
Certain use cases need to use only specific ENIs for pod IPs similar to allow and deny list. Currently we support no_manage = true tag but certain use cases need no_manage=false.
What does this PR do / Why do we need it:
no_manage=falsewill take precedence and will be considered for pod IP allocation and IfMANAGE_UNTAGGED_ENI=falseis set then any untagged ENIs will be marked as unmanaged by IPAMD and will not be considered for pod IP allocation.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
yes.
Automation added to e2e:
Will update in a follow up PR.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.