Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1591

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

wafuwafu13
Copy link
Contributor

What type of PR is this?
documentation

Which issue does this PR fix:
Nothing

What does this PR do / Why do we need it:
Be easy to read

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Nothing

Testing done on this change:

Nothing

Automation added to e2e:

Nothing

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Nothing

Does this change require updates to the CNI daemonset config files to work?:

Nothing

Does this PR introduce any user-facing change?:

Nothing


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. lgtm

@jayanthvn jayanthvn merged commit beee06a into aws:master Aug 26, 2021
cgchinmay added a commit to cgchinmay/amazon-vpc-cni-k8s that referenced this pull request Aug 30, 2021
Update documentation for PD (aws#1539)

Update SDK Go version (aws#1542)

* Update SDK Go version

* missed mod file

Bump helm.sh/helm/v3 from 3.2.0 to 3.6.1 in /test (aws#1545)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.2.0 to 3.6.1.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.2.0...v3.6.1)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Update CNI charts image version (aws#1543)

* Update CNI charts image version

* updated the labels

* CRD update

* update charts version

* minor nits

* fix charts ver

* fix charts ver

Cherry-pick to master - (aws#1551) (aws#1552)

* Release - v1.9.0 (aws#1551)

* update markdown

Update prefix-and-ip-target.md (aws#1553)

Grammar fixes

Use codecov github action (aws#1550)

In particular, this avoids `curl | bash` (the bash script is simply
embedded in the github action image).

It also provides a trivial upgrade path to the new nodejs-based
uploader (`@v1` -> `@v2`), when we decide that is ready (perhaps now).

Added Multus artifacts to config folder (aws#1563)

Added Readme for Multus Installation

Updated configMap in daemonset to use aws-vpc-cni as default delegate instead of flannel

Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com>

set requests/limits for initcontainer (aws#1559)

Documentation update (aws#1565)

* Doc update

* more updates

set multus log level to panic instead of debug (aws#1567)

Updated Readme for Multus logging info

Changed log level to error instead of debug

Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com>

WARM targets can be set non-negative (aws#1568)

Generate calico artifacts from helm (aws#1541)

* Generate calico manifests from helm

* Update CNI charts image version

* Testing release workflow<Do-not-merge>

* Testing workflow

* Updating workflow

* set matchlabels while generating manifests

* Copy generated manifests to master/config folder

* update to match the release branch

* update operator to v1.13.8

* update version

Change github_token permission (aws#1577)

Bandwidth plugin support (aws#1560)

* bandwidth plugin support

* update netns

Update new instance types (aws#1576)

Updated multus ds manifest file for v3.7.2-eksbuild.2 (aws#1583)

* Updated multus ds manifest file for v3.7.2-eksbuild.2

Remove Node Affinity for amd64 from manifest so that it can run on arm64 as well

* revert log-level to error for multus

Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com>

Modify integ test workflow (aws#1579)

* Change github_token permission

* - Modified permissions for github_token in cron and integ test workflow
- Modified integ test workflow to run on push to master and release branches

Upgrading controller-runtime is test dir (aws#1582)

Update Ginkgo command params example in the doc (aws#1589)

Update CONTRIBUTING.md (aws#1591)

Fix region/account for manifests generated from helm (aws#1592)

* Yamls generated from helm was missing region/account override

* fix domains

Updated snat rule test logic

Install iptables in the test agent image
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this pull request Aug 31, 2021
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants