cherry-pick PR-1279 into release-1.8 #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tryAssignIPs would always allocate all available IPs on the ENI regardless of the number of IPs the node would want. A great showcase of this behavior is on node bootstrap. Assuming we have a node with maxIPsPerENI=30 and WARM_IP_TARGET=5, the following happens: - Node starts with single IP - tryAssignIPs allocates an additional 29 IPs - decreaseIPPool will release 29-5=24 IPs After the change this would look like: - Node starts with a single IP - tryAssignIPs allocates an additional 5 IPs So in this very common flow we cut out an entire AWS API call per node. In addition this behavior exhibits itself any time we need to scale up IPs as tryAssignIPs always attempts to over-allocate IPs -- which then just need to be released almost immediately. Fixes aws#1272
achevuru
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tryAssignIPs would always allocate all available IPs on the
ENI regardless of the number of IPs the node would want. A great
showcase of this behavior is on node bootstrap. Assuming we have a node
with maxIPsPerENI=30 and WARM_IP_TARGET=5, the following happens:
After the change this would look like:
So in this very common flow we cut out an entire AWS API call per node.
In addition this behavior exhibits itself any time we need to scale up
IPs as tryAssignIPs always attempts to over-allocate IPs -- which then
just need to be released almost immediately.
Fixes #1272
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
cherry-pick PR-1279 into release-1.8
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.