Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'exec' ENTRYPOINTs #1432

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Use 'exec' ENTRYPOINTs #1432

merged 1 commit into from
Apr 19, 2021

Conversation

anguslees
Copy link
Contributor

@anguslees anguslees commented Apr 19, 2021

Switch from 'shell' to 'exec' ENTRYPOINTs. This removes an
unnecessary intermediate shell process, and ensures that k8s
termination signals are delivered to the correct process[*].

[*] We don't need graceful shutdown, so this is mostly a best-practices cleanup and not a bugfix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Switch from 'shell' to 'exec' ENTRYPOINTs.  This removes an
unnecessary intermediate shell process, and ensures that k8s
termination signals are delivered to the correct process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants