-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Test cases for EnvVars check on CNI daemonset #1431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)..will wait for Abhinav to review.
abhipth
reviewed
Apr 22, 2021
abhipth
reviewed
Apr 23, 2021
couralex6
reviewed
Apr 23, 2021
fawadkhaliq
suggested changes
Apr 23, 2021
couralex6
approved these changes
Apr 23, 2021
- folder restructuring
abhipth
reviewed
Apr 26, 2021
# Conflicts: # test/integration-new/ipamd/ipamd_suite_test.go
# Conflicts: # test/framework/resources/k8s/manifest/deployment.go # test/framework/resources/k8s/resources/node.go # test/go.mod
abhipth
reviewed
May 5, 2021
abhipth
reviewed
May 5, 2021
Removed unnecessary tests Addressed PR comments
cgchinmay
commented
May 5, 2021
abhipth
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following improvements can be made in subsequent iterations
- Use test helper docker image to test MTU
- Instead of deploying a deployment with single replica and getting the pod from the deployment. Deploy a single pod. The utility method for the same will be available once the PR is merged.
abhipth
approved these changes
May 6, 2021
fawadkhaliq
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Added ginkgo test for testing env vars on cni daemonset
What does this PR do / Why do we need it:
Need CNI automation using Ginkgo framework
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
Assumes using latest CNI
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.