Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed formatting #1418

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fixed formatting #1418

merged 2 commits into from
Apr 7, 2021

Conversation

jayanthvn
Copy link
Contributor

@jayanthvn jayanthvn commented Apr 6, 2021

What type of PR is this?
Fix formatting and go version for GitHub actions

cleanup

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:
Go version while building UTs is using 1.16 and it is failing in make format but with 1.14 not seeing issues. So for now changing it to 1.14.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
n/a

Testing done on this change:

Need to merge to verify

Automation added to e2e:

n/a

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
n/a

Does this change require updates to the CNI daemonset config files to work?:

n/a

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jayanthvn jayanthvn marked this pull request as draft April 6, 2021 21:32
Copy link
Contributor

@couralex6 couralex6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jayanthvn jayanthvn marked this pull request as ready for review April 7, 2021 16:38
@jayanthvn jayanthvn merged commit 9db2ae6 into aws:master Apr 7, 2021
@jayanthvn jayanthvn changed the title Fixed formatting - WIP Fixed formatting Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants