Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion of hostVeth rule for pods using security group #1376

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

SaranBalaji90
Copy link
Contributor

What type of PR is this?
bug

Which issue does this PR fix:
#1375
#1374

What does this PR do / Why do we need it:
This cleans up any dangling resources for old pods using same name. This might happen if pods are force deleted.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:
Tested on dev cluster and verified the dangling rules are deleted before adding new routes.

[ec2-user@ip-192-168-65-167 ~]$ ip rule
10:	from all iif vlan.eth.1 lookup 101 
10:	from all iif vlan.eth.2 lookup 102 
10:	from all iif vlanaad671050aa [detached] lookup 101 
20:	from all lookup local 
[ec2-user@ip-192-168-65-167 ~]$ ip rule
10:	from all iif vlan.eth.1 lookup 101 
10:	from all iif vlan.eth.2 lookup 102 
10:	from all iif vlanaad671050aa lookup 102 
20:	from all lookup local 
[ec2-user@ip-192-168-65-167 ~]$ 

Automation added to e2e:
NA

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jayanthvn jayanthvn merged commit 99ecb4c into aws:master Feb 5, 2021
@jayanthvn jayanthvn added this to the V1.7.9 milestone Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants