upgrade github.com/containernetworking/plugins to v0.9.0 #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fawadkhaliq
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
++, thanks for updating the dependency
This will need an e2e integration test run and then it's good to merge. (cc: @jayanthvn @couralex6 - I know you're updating the CI workers, can we please trigger the on-demand test on this PR)
Here's the changelog for the plugins v0.9.0 release: https://github.com/containernetworking/plugins/releases/tag/v0.9.0
jayanthvn
approved these changes
Jan 15, 2021
|
@jayanthvn @fawadkhaliq rebased the PR. |
|
Thanks for taking care of it. I will merge and run integration test on this thru circle ci. |
|
@fr0stbyte Were you able to verify if this fix solves your issue? |
This was referenced Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
containernetworking/plugins#553
What does this PR do / Why do we need it:
conntrack table is not flushed for UDP hostPorts when pod is deleted. This has been fixed in the newer version of containernetworking/plugins (PR with the fix is linked above)
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
n/a
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Not tested beyond unittests
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
Not that I am aware of
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.