Adds timeout to HTTP clients #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix.
Which issue does this PR fix:
#1256
What does this PR do / Why do we need it:
Some customers experienced a stuck go routine caused by stuck http requests not timing out.
Testing done on this change:
Manually tested the two following scenarios:
HTTP_TIMEOUTin the yaml and logging the set value.Automation added to e2e:
None
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Will not break downgrades or upgrades.
Does this change require updates to the CNI daemonset config files to work?:
Only if we decide to include the HTTP_TIMEOUT var in the config file.
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.