Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Pod deletion workflow #1315

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

SaranBalaji90
Copy link
Contributor

@SaranBalaji90 SaranBalaji90 commented Dec 7, 2020

What type of PR is this?
bug

Which issue does this PR fix:
If regular pods are force deleted when PPSG is used then it will clean up the regular pods.

What does this PR do / Why do we need it:
If we do make this change, then force deleting regular pods will not be supported with PPSG.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
This doesn't change any existing functionality.

Testing done on this change:
Created and deleted regular pods.

Created and deleted branch eni pods -

{"level":"info","ts":"2020-12-08T00:46:39.198Z","caller":"rpc/rpc.pb.go:520","msg":"Received DelNetwork for Sandbox 7e8fa75d4ccb574d391d5e72b6d07c395ed344cd95984135ddfc74e7c9316c89"}
{"level":"debug","ts":"2020-12-08T00:46:39.198Z","caller":"rpc/rpc.pb.go:520","msg":"DelNetworkRequest: ClientVersion:\"varavaj-init-v2-67-g8bd8af2c\" K8S_POD_NAME:\"gw-74464d8645-vz4b9\" K8S_POD_NAMESPACE:\"default\" K8S_POD_INFRA_CONTAINER_ID:\"7e8fa75d4ccb574d391d5e72b6d07c395ed344cd95984135ddfc74e7c9316c89\" Reason:\"PodDeleted\" ContainerID:\"7e8fa75d4ccb574d391d5e72b6d07c395ed344cd95984135ddfc74e7c9316c89\" IfName:\"eth0\" NetworkName:\"aws-cni\" "}
{"level":"debug","ts":"2020-12-08T00:46:39.198Z","caller":"ipamd/rpc_handler.go:198","msg":"UnassignPodIPv4Address: IP address pool stats: total:28, assigned 1, sandbox aws-cni/7e8fa75d4ccb574d391d5e72b6d07c395ed344cd95984135ddfc74e7c9316c89/eth0"}
{"level":"debug","ts":"2020-12-08T00:46:39.198Z","caller":"ipamd/rpc_handler.go:198","msg":"UnassignPodIPv4Address: Failed to find IPAM entry under full key, trying CRI-migrated version"}
{"level":"warn","ts":"2020-12-08T00:46:39.198Z","caller":"ipamd/rpc_handler.go:198","msg":"UnassignPodIPv4Address: Failed to find sandbox _migrated-from-cri/7e8fa75d4ccb574d391d5e72b6d07c395ed344cd95984135ddfc74e7c9316c89/unknown"}

Branch ENI deleted successfully.

Automation added to e2e:
N/A

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No this doesn't break on upgrades/downgrades

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants