-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calico to v3.16.2 #1235
Merged
Merged
Update calico to v3.16.2 #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
approved these changes
Sep 29, 2020
@jayanthvn Any idea when you might get round to reviewing this? |
Hi @lwr20 Will review it asap. Also would like to work with you on adding calico tests to our integration suite. Thanks. |
jayanthvn
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this.
jayanthvn
pushed a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Nov 30, 2020
* Update calico to v3.16.1 * Allow KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT override in Typha too * Update to v3.16.2
Merged
jayanthvn
pushed a commit
that referenced
this pull request
Nov 30, 2020
* Update calico to v3.16.1 * Allow KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT override in Typha too * Update to v3.16.2
haouc
pushed a commit
to haouc/amazon-vpc-cni-k8s
that referenced
this pull request
Dec 2, 2020
* Update calico to v3.16.1 * Allow KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT override in Typha too * Update to v3.16.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup (updating images and fixing config)
Which issue does this PR fix:
n/a.
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
n/a
Testing done on this change:
Manually set up an eks cluster following https://docs.aws.amazon.com/eks/latest/userguide/calico.html but substituting this calico.yaml. Then ran some workloads and verified that pod and service connectivity was working.
Automation added to e2e:
If this updated calico.yaml doesn't get picked up by existing tests, happy to work with someone to make that happen.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Not expected to break upgrades or downgrades, but I've not explicitly tested that.
Does this change require updates to the CNI daemonset config files to work?:
This change is itself an update to the CNI daemonset.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.