Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt, vet and ineffassign issues #117

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Jun 27, 2018

Issue #91

Description of changes:

  • Add BuildStatus badge
  • Add GoReport badge
  • Fix all GoReport issues except the missing comments

Needs TravisCI to be enabled for the aws/amazon-vpc-cni-k8s repository.

Example how the badges look for my branch:

BuildStatus Widget GoReport Widget

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@liwenwu-amazon liwenwu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@liwenwu-amazon liwenwu-amazon merged commit 2083363 into aws:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants