Write to IPAM checkpoint file immediately after reading from CRI #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current migration logic has a corner case: if we upgrade 1.6->1.7->1.8 and _never_ see a pod create/delete during the 1.7 phase, then we never write the IPAM checkpoint file. This change just writes the file immediately after reading state from CRI, if in migration phase1.
jayanthvn
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current migration logic has a corner case: if we upgrade
1.6->1.7->1.8 and never see a pod create/delete during the 1.7
phase, then we never write the IPAM checkpoint file.
This change just writes the file immediately after reading state from
CRI, if in migration phase1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.