Changed data type for variables: AWS_VPC_K8S_CNI_CUSTOM_NETWORK_CFG a… #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd WARM_ENI_TARGET to String
|
Hmm... Technically, looking at the env settings in the sample config, they are all strings, but contains different types of values. |
|
That's a good suggestion! I can do that. Should I change other variables' type to reflect this too or just the ones mentioned in #186? |
|
@abhinavmpandey08 I think we should fix the documentation for all ENV variables at the same time. :) |
mogren
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Thanks @abhinavmpandey08, and congrats on being contributor 100 to this project! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd WARM_ENI_TARGET to String
Issue #, if available: #186
Description of changes: Updated variable type of
AWS_VPC_K8S_CNI_CUSTOM_NETWORK_CFGfromBooleantoStringandWARM_ENI_TARGETfromIntegertoString.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.