-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle EKS created ENI sg update #1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithu0115
suggested changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayanthvn thanks for making this change. This requires few changes. Please see comments!
jayanthvn
force-pushed
the
sg_update_fix
branch
5 times, most recently
from
August 5, 2020 15:18
54c8d13
to
e94d4ba
Compare
mogren
suggested changes
Aug 5, 2020
jayanthvn
force-pushed
the
sg_update_fix
branch
2 times, most recently
from
August 18, 2020 18:59
68abd73
to
bf7f147
Compare
mogren
suggested changes
Aug 18, 2020
jayanthvn
force-pushed
the
sg_update_fix
branch
2 times, most recently
from
August 18, 2020 20:49
04361ac
to
b72b7ac
Compare
mogren
suggested changes
Aug 18, 2020
jayanthvn
force-pushed
the
sg_update_fix
branch
from
August 19, 2020 03:01
4c39f32
to
088b2f7
Compare
mogren
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @jayanthvn! Requires a rebase though.
jayanthvn
force-pushed
the
sg_update_fix
branch
from
August 19, 2020 06:24
088b2f7
to
29f9e56
Compare
jayanthvn
force-pushed
the
sg_update_fix
branch
from
August 19, 2020 06:25
29f9e56
to
a7506f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #964
Description of changes:
Currently when security group is updated to a worker node only the primary ENI was getting updated but not the EKS created ENIs. With this fix - when the security group is refreshed, check is made if new security groups are added or if some are deleted. Based on that security group update is called for all the attached ENIs.
On adding a new SG, all 3 ENIs are getting updated -
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.