-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover bottlerocket cluster test. #1096
Conversation
# Conflicts: # scripts/run-integration-tests.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for adding
@@ -73,7 +73,7 @@ jobs: | |||
- run: | |||
name: Run the integration tests | |||
command: ./scripts/run-integration-tests.sh | |||
no_output_timeout: 15m | |||
no_output_timeout: 20m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's that slow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eksctl can sometimes take longer than 15m to create the cluster and mng, so it did timeout once. Haven't seen any problems after moving it to 20m!
if [[ $RUN_KOPS_TEST == true || $RUN_BOTTLEROCKET_TEST == true ]]; then | ||
KUBECTL_PATH=kubectl | ||
export KUBECONFIG=~/.kube/config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so both Kops and eksctl needs these to be set.
scripts/run-integration-tests.sh
Outdated
if [[ "$RUN_BOTTLEROCKET_TEST" == true ]]; then | ||
echo "TESTING downloading eksctl" | ||
curl --silent --location "https://github.com/weaveworks/eksctl/releases/latest/download/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp | ||
sudo mv -v /tmp/eksctl /usr/local/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please place the above code into an ensure_eksctl
Bash function (similar to ensure_ecr_repo
and ensure_aws_k8s_tester
functions.
scripts/run-integration-tests.sh
Outdated
fi | ||
UP_CLUSTER_DURATION=$((SECONDS - START)) | ||
echo "TIMELINE: Upping test cluster took $UP_CLUSTER_DURATION seconds." | ||
__cluster_created=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to set __cluster_created=1
above, since it's set on line 173 below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bingo, thanks @bnapolitan!
Create cluster using bottlerocket configuration. Ensure integration/conformance tests pass across this cluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.