Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover bottlerocket cluster test. #1096

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Conversation

bnapolitan
Copy link
Contributor

Create cluster using bottlerocket configuration. Ensure integration/conformance tests pass across this cluster.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding

@@ -73,7 +73,7 @@ jobs:
- run:
name: Run the integration tests
command: ./scripts/run-integration-tests.sh
no_output_timeout: 15m
no_output_timeout: 20m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's that slow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eksctl can sometimes take longer than 15m to create the cluster and mng, so it did timeout once. Haven't seen any problems after moving it to 20m!

Comment on lines +187 to +189
if [[ $RUN_KOPS_TEST == true || $RUN_BOTTLEROCKET_TEST == true ]]; then
KUBECTL_PATH=kubectl
export KUBECONFIG=~/.kube/config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so both Kops and eksctl needs these to be set.

if [[ "$RUN_BOTTLEROCKET_TEST" == true ]]; then
echo "TESTING downloading eksctl"
curl --silent --location "https://github.com/weaveworks/eksctl/releases/latest/download/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp
sudo mv -v /tmp/eksctl /usr/local/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place the above code into an ensure_eksctl Bash function (similar to ensure_ecr_repo and ensure_aws_k8s_tester functions.

fi
UP_CLUSTER_DURATION=$((SECONDS - START))
echo "TIMELINE: Upping test cluster took $UP_CLUSTER_DURATION seconds."
__cluster_created=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to set __cluster_created=1 above, since it's set on line 173 below.

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bingo, thanks @bnapolitan!

@jaypipes jaypipes merged commit a1e94bf into aws:master Jul 21, 2020
@bnapolitan bnapolitan deleted the bottlerocket-test branch July 22, 2020 22:28
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this pull request Aug 11, 2020
SaranBalaji90 pushed a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants