Use sed as a stream editor and redirect to file #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaypipes could you review this please? |
|
@mogren can you check this out too please? |
mogren
suggested changes
Jul 9, 2020
anguslees
reviewed
Jul 9, 2020
anguslees
approved these changes
Jul 9, 2020
mogren
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can't easily provide your own config file for the cni. Mounting a file from a configmap is readonly, and the magical find replace that sed does is inline against the existing file fails. Instead, I am proposing that we copy the file to a tempfile and modify that before we copy it to its destination.
I thought about perhaps having an environment variable for a custom template file, flag, or similar, but I think that actually that could cause more complexity in the entrypoint script, and I didn't want to change the behavior that much.
Sorry for the 'ergh' next to the sed comment, I wanted to show that I wasn't a fan of how this works, the sedding of config files 🤣. I appreciate why this is done here though.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.