Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated manifest configs with default env vars #1057

Merged
merged 2 commits into from
Jun 25, 2020
Merged

updated manifest configs with default env vars #1057

merged 2 commits into from
Jun 25, 2020

Conversation

saiteja313
Copy link
Contributor

*Issue #1053

Description of changes:
Updated Readme with a missing environment variable description i.e., AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER

Also, updated manifests.jsonnet file with missing default environment variables.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saiteja313, just a minor change needed.

README.md Show resolved Hide resolved
config/master/aws-k8s-cni.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants