Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init.sh script fails when grep for primary IP returns multiple matches #1246

Closed
kishorj opened this issue Oct 2, 2020 · 0 comments · Fixed by #1247
Closed

init.sh script fails when grep for primary IP returns multiple matches #1246

kishorj opened this issue Oct 2, 2020 · 0 comments · Fixed by #1247
Labels
bug priority/P0 Highest priority. Someone needs to actively work on this.

Comments

@kishorj
Copy link
Contributor

kishorj commented Oct 2, 2020

What happened:

The grep in the code

amazon-vpc-cni-k8s/scripts/init.sh

Line 28 in 59cd4ae

PRIMARY_IF=$(ip -4 -o a | grep "$HOST_IP" | awk '{print $2}')
could potentially return more than one match, causing the script to fail.
Here is an example when it fails -

eth0: 192.168.0.10
eth1: 192.168.0.100

Failure occurs during upgrade.
What you expected to happen:
Upgrade to amazon-k8s-cni:v1.7.3 is succcessful

How to reproduce it (as minimally and precisely as possible):
Use the IP addresses from the description.
Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): any
  • CNI Version: on upgrade to amazon-k8s-cni:v1.7.3 under right conditions
  • OS (e.g: cat /etc/os-release): any
  • Kernel (e.g. uname -a): any
@kishorj kishorj added the bug label Oct 2, 2020
@kishorj kishorj changed the title init.sh script fails when grep for primary IP matches multiple IPs init.sh script fails when grep for primary IP returns multiple matches Oct 2, 2020
@mogren mogren added the priority/P0 Highest priority. Someone needs to actively work on this. label Oct 2, 2020
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Oct 2, 2020
Match primary ENI IP correctly
6faebcb 
Fixes aws#1246
@mogren mogren mentioned this issue Oct 2, 2020
Merged
mogren pushed a commit that referenced this issue Oct 2, 2020
@mogren
Match primary ENI IP correctly
47f1bc4 
Fixes #1246
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this issue Oct 6, 2020
@haouc
Match primary ENI IP correctly
57324b3 
Fixes aws#1246
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this issue Oct 7, 2020
@haouc
Match primary ENI IP correctly
38f7da9 
Fixes aws#1246
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this issue Oct 7, 2020
@haouc
Match primary ENI IP correctly
a7dbce6 
Fixes aws#1246
@haouc haouc mentioned this issue Oct 7, 2020
Merged
jayanthvn pushed a commit that referenced this issue Oct 7, 2020
@jayanthvn
Match primary ENI IP correctly
11f82f9 
Fixes #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority/P0 Highest priority. Someone needs to actively work on this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match primary ENI IP correctly mogren/amazon-vpc-cni-k8s
2 participants
@mogren @kishorj