Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for .NET SDK V4 #60

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

philasmar
Copy link
Contributor

Description

  • Removed the net35 target, updated net45 to net472 and added a net8 target.
  • Removed the custom preprocessor directives and used the native ones
  • Update the .NET SDK dependencies to the latest version 4.0.0.preview.2
  • Deleted parts of the code that still reference AmazonS3EncryptionClient from the SDK, which was deleted.
  • Disable obsolete warnings related to AmazonS3EncryptionClient which we agreed not to remove from this version of the library
  • Removed blocks of code that are related to net35

Motivation and Context

This change updates the library to use .NET SDK V4 and allows customers that are wanting to upgrade to .NET SDK V4 to continue using this library.

Testing

  • Ran the unit tests and integrations tests locally and they passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -0,0 +1,11 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the configuration file to use AutoVer in the repo

@@ -0,0 +1,13 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the changelog that will be used for 3.0.0-preview.1

@@ -1,41 +1,65 @@
# Change log
## Release 2024-09-03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the existing changelog file to match the AutoVer format

@philasmar philasmar requested a review from normj September 6, 2024 19:53
@philasmar philasmar merged commit 4ce4351 into v4sdk-development Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants