Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceURL option for KMS client #45

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Conversation

bdurrani
Copy link
Contributor

@bdurrani bdurrani commented Aug 7, 2023

AmazonKeyManagementServiceConfig doesn't use the service url when it's setting on AmazonS3CryptoConfigurationV2

Description

Motivation and Context

I'm using LocalStack when I set ServiceURL on AmazonS3CryptoConfigurationV2 I'm seeing the Kms calling aws endpoint

See #29 for reference

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@bdurrani bdurrani marked this pull request as ready for review August 7, 2023 02:19
@bdurrani
Copy link
Contributor Author

bdurrani commented Aug 7, 2023

@normj Hi there
Is this change ok for the KMS client ServiceURL option?
As discussed here: #29

Thanks

src/AmazonS3EncryptionClientBase.cs Outdated Show resolved Hide resolved
src/AmazonS3CryptoConfigurationBase.cs Show resolved Hide resolved
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll line up a second reviewer from the internal team. We'll also handle the version bump once approved.

@ashovlin
Copy link
Member

I've merged this to dev, which is our staging branch for the next release. We'll reply again once the new release is out.

jnunn-aws added a commit that referenced this pull request Aug 17, 2023
Merge PR #45 "Add ServiceURL option for KMS client" and PR#46 "Version Bump & .NET 6"
@ashovlin
Copy link
Member

This PR was released yesterday in 2.1.0, thanks again for your contribution!

@bdurrani bdurrani deleted the kms-service-rul branch August 20, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants