-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceURL option for KMS client #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll line up a second reviewer from the internal team. We'll also handle the version bump once approved.
I've merged this to |
Merge PR #45 "Add ServiceURL option for KMS client" and PR#46 "Version Bump & .NET 6"
This PR was released yesterday in 2.1.0, thanks again for your contribution! |
AmazonKeyManagementServiceConfig doesn't use the service url when it's setting on AmazonS3CryptoConfigurationV2
Description
Motivation and Context
I'm using LocalStack when I set ServiceURL on AmazonS3CryptoConfigurationV2 I'm seeing the Kms calling aws endpoint
See #29 for reference
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License