Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using go-version file to resolve go version #90

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Mar 15, 2024

What type of PR is this?

improvement
Which issue does this PR fix:
We want to use a go-version file to resolve the go version for image build.

What does this PR do / Why do we need it:

If an issue # is not available please add steps to reproduce and the controller logs:

Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haouc haouc requested a review from a team as a code owner March 15, 2024 22:51
Copy link
Contributor

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haouc haouc merged commit 0b9c7be into aws:main Mar 16, 2024
4 checks passed
@haouc haouc deleted the goversion branch March 16, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants