Update dependency for golang.org/x/sys/windows #281
Conversation
| @@ -516,7 +513,7 @@ | |||
| }, | |||
| { | |||
| "ImportPath": "golang.org/x/sys/windows", | |||
| "Rev": "478fcf54317e52ab69f40bb4c7a1520288d7f7ea" | |||
| "Rev": "99f16d856c9836c42d24e7ab64ea72916925fa97" | |||
There was a problem hiding this comment.
It looks like only the SHA was changed, without changing any of the vendored files. You'll need to check in the vendored files as well.
There was a problem hiding this comment.
So, after some digging, it would appear that the changes in 99f16d856c9836c42d24e7ab64ea72916925fa97 for golang.org/x/sys/windows are already reflected in the /vendor directory, but the revision SHA wasn't updated in the manifest. Checking out that version of the package and comparing it against what we have in our code, it looks like there are no real differences:
https://gist.github.com/SoManyHs/736f38ee56f818aeefa596dbf3791a7c
There was a problem hiding this comment.
Well that seems broken. Thanks!
There was a problem hiding this comment.
Yep. It would appear to maybe be related to a known issue with godep restore: tools/godep#453
NOTE: The vendored files were already checked in in an earlier commit, but due to a series of unfortunate events the revision SHA was not updated properly. This remedies the discrepency.
No description provided.