ecs-init: upgrade github.com/docker/docker -> v25.0.6 #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
changed the title
amogh09
approved these changes
Jan 3, 2025
prateekchaudhry
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
github.com/docker/dockerto v25.0.6 in the ecs-init module.Implementation details
Upon upgrading the version, and running
go mod tidy, we see thatpkg/aaparserwas removed from the docker codebase. This is the PR where it was removed: moby/moby#47005.We use the LoadProfile() method that was moved to an internal pkg in docker and unexported, breakng external usage like ours. In order to resolve this issue, this PR copies the loadProfile() from the docker codebase into the ecs-init module.
Testing
New tests cover the changes: No, relying on existing automated PR checks. I also ran the functional tests by replacing ecs init on the instance, with the ecs init built from this PR – tests passed.
Description for the changelog
Enhancement: upgrade github.com/docker/docker to v25.0.6 in ecs-init module
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.