-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD-1017] Implement single-instance SSH tunnel. #453
Conversation
* Handle late-bound invocation (DbVisualizer) * Ensure support for multiple hash algorithms. * Properly embed new SSH tunnel component.
Note: original merged commit is f59af169fe9641c5f593f3e1a261e91dedf7a2ed on #436. |
src/main/java/software/amazon/documentdb/jdbc/sshtunnel/DocumentDbSshTunnelServer.java
Show resolved
Hide resolved
src/test/java/software/amazon/documentdb/jdbc/DocumentDbConnectionTest.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/sshtunnel/DocumentDbSshTunnelService.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbMain.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbMain.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
…tionProperties.java Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke test on schema CLI has shown an issue with the log output not going to the console. Suspect the new dependency on
com.github.mwiede:jsch
to be the cause of this issue.Will not merge until log output works correctly to be sent to console, as expected.
Issue was logging level of the output had incorrectly been changed from ERROR to INFO. Changing back to ERROR level resolved the issue.
…change level from INFO to ERROR).
…aws/amazon-documentdb-jdbc-driver into birschick-bq/ad-1017/ssh-tunnel
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 52 files 52 suites 12m 17s ⏱️ Results for commit 173e8a4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
* [AD-1017] Implement single-instance SSH tunnel. * Handle late-bound invocation (DbVisualizer) * Ensure support for multiple hash algorithms. * Properly embed new SSH tunnel component. * [AD-1017] Attempt to debug multi-process test. * [AD-1017] Attempt to debug multi-process test. * [AD-1017] Attempt to debug multi-process test - aws#3. * Commit Code Coverage Badge * [AD-1017] Attempt to find correct location for test source file. * [AD-1017] Attempt to find correct location for test source file - aws#2. * [AD-1017] Fix spotBugs error; code review improvements. * [AD-1017] Ignore IO exceptions when reading spawned processes. * Commit Code Coverage Badge * [AD-1017] Update dependency for mongo to 4.8.1 * Commit Code Coverage Badge * [AD-1017] Attempt improve stability of SSH Tunnel client tests. * [AD-1017] Attempt improve stability of multiprocess connection test. * Commit Code Coverage Badge * Update src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com> * [AD-1017] Properly rename parameter. * Commit Code Coverage Badge * [AD-1017] Fix issue with output not being sent to the console (i.e., change level from INFO to ERROR). * Commit Code Coverage Badge * [AD-1017] Attempt to increase code coverage. * [AD-1017] Fix style issue. * Commit Code Coverage Badge Co-authored-by: birschick-bq <birschick-bq@users.noreply.github.com> Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com>
Summary
[AD-1017] Implement single-instance SSH tunnel.
Description
Related Issue
https://bitquill.atlassian.net/browse/AD-1017
Additional Reviewers
@affonsoBQ
@alinaliBQ
@andiem-bq
@alexey-temnikov
@birschick-bq