[AD-1017] Implement single-instance SSH tunnel. #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle late-bound invocation (DbVisualizer) * Ensure support for multiple hash algorithms. * Properly embed new SSH tunnel component.
|
Note: original merged commit is f59af169fe9641c5f593f3e1a261e91dedf7a2ed on #436. |
birschick-bq
commented
Dec 6, 2022
src/main/java/software/amazon/documentdb/jdbc/sshtunnel/DocumentDbSshTunnelServer.java
Show resolved
Hide resolved
src/test/java/software/amazon/documentdb/jdbc/DocumentDbConnectionTest.java
Outdated
Show resolved
Hide resolved
birschick-bq
commented
Dec 6, 2022
src/main/java/software/amazon/documentdb/jdbc/sshtunnel/DocumentDbSshTunnelService.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbMain.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/documentdb/jdbc/DocumentDbMain.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alinaliBQ
reviewed
Dec 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java
Outdated
Show resolved
Hide resolved
…tionProperties.java Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
birschick-bq
commented
Dec 16, 2022
There was a problem hiding this comment.
Smoke test on schema CLI has shown an issue with the log output not going to the console. Suspect the new dependency on
com.github.mwiede:jschto be the cause of this issue.Will not merge until log output works correctly to be sent to console, as expected.
Issue was logging level of the output had incorrectly been changed from ERROR to INFO. Changing back to ERROR level resolved the issue.
added 2 commits
December 16, 2022 10:45
…change level from INFO to ERROR).
…aws/amazon-documentdb-jdbc-driver into birschick-bq/ad-1017/ssh-tunnel
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 52 files 52 suites 12m 17s ⏱️ Results for commit 173e8a4. |
normanj-bitquill
pushed a commit
to normanj-bitquill/amazon-documentdb-jdbc-driver
that referenced
this pull request
Dec 27, 2022
* [AD-1017] Implement single-instance SSH tunnel. * Handle late-bound invocation (DbVisualizer) * Ensure support for multiple hash algorithms. * Properly embed new SSH tunnel component. * [AD-1017] Attempt to debug multi-process test. * [AD-1017] Attempt to debug multi-process test. * [AD-1017] Attempt to debug multi-process test - aws#3. * Commit Code Coverage Badge * [AD-1017] Attempt to find correct location for test source file. * [AD-1017] Attempt to find correct location for test source file - aws#2. * [AD-1017] Fix spotBugs error; code review improvements. * [AD-1017] Ignore IO exceptions when reading spawned processes. * Commit Code Coverage Badge * [AD-1017] Update dependency for mongo to 4.8.1 * Commit Code Coverage Badge * [AD-1017] Attempt improve stability of SSH Tunnel client tests. * [AD-1017] Attempt improve stability of multiprocess connection test. * Commit Code Coverage Badge * Update src/main/java/software/amazon/documentdb/jdbc/DocumentDbConnectionProperties.java Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com> * [AD-1017] Properly rename parameter. * Commit Code Coverage Badge * [AD-1017] Fix issue with output not being sent to the console (i.e., change level from INFO to ERROR). * Commit Code Coverage Badge * [AD-1017] Attempt to increase code coverage. * [AD-1017] Fix style issue. * Commit Code Coverage Badge Co-authored-by: birschick-bq <birschick-bq@users.noreply.github.com> Co-authored-by: Alexey Temnikov <alexeyt@bitquilltech.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[AD-1017] Implement single-instance SSH tunnel.
Description
Related Issue
https://bitquill.atlassian.net/browse/AD-1017
Additional Reviewers
@affonsoBQ
@alinaliBQ
@andiem-bq
@alexey-temnikov
@birschick-bq