Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mongo Driver Information #433

Merged
merged 35 commits into from
Dec 14, 2022
Merged

Conversation

affonsov
Copy link
Contributor

@affonsov affonsov commented Nov 3, 2022

Summary

Add Mongo Driver Information

Description

Send the application name and driver version to the MongoDriverInformation - to support CloudWatch telemetry.

Related Issue

https://bitquill.atlassian.net/browse/AD-1032

Additional Reviewers

@affonsoBQ
@alinaliBQ
@andiem-bq
@alexey-temnikov
@birschick-bq

dependabot bot and others added 13 commits October 4, 2022 00:40
Bumps commons-text from 1.9 to 1.10.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.github.spotbugs from 5.0.10 to 5.0.13.

---
updated-dependencies:
- dependency-name: com.github.spotbugs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.8.0...v4.8.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sslcontext-kickstart](https://github.com/Hakky54/sslcontext-kickstart) from 7.4.7 to 7.4.8.
- [Release notes](https://github.com/Hakky54/sslcontext-kickstart/releases)
- [Changelog](https://github.com/Hakky54/sslcontext-kickstart/blob/master/CHANGELOG.md)
- [Commits](Hakky54/sslcontext-kickstart@v7.4.7...v7.4.8)

---
updated-dependencies:
- dependency-name: io.github.hakky54:sslcontext-kickstart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.3.4 to 10.4.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.3.4...checkstyle-10.4)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ppycrawl.tools-checkstyle-10.4' into develop
…hub.hakky54-sslcontext-kickstart-7.4.8' into develop
…ache.commons-commons-text-1.10.0' into develop
@github-actions

This comment has been minimized.

@affonsov affonsov force-pushed the affonsov/add-mongodriverinformation branch from 57ed601 to 6d14e9e Compare November 4, 2022 21:37
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@affonsov affonsov marked this pull request as ready for review December 9, 2022 18:14
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

  49 files  ±    0    49 suites  ±0   10m 4s ⏱️ + 7m 12s
628 tests +155  628 ✔️ +155  0 💤 ±0  0 ❌ ±0 
638 runs  +160  638 ✔️ +160  0 💤 ±0  0 ❌ ±0 

Results for commit a7d971f. ± Comparison against base commit 68db459.

Copy link
Contributor

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Has the JDBC driver been tested with CloudWatch to ensure that CloudWatch telemetry is supported?

@birschick-bq
Copy link
Contributor

The changes LGTM. Has the JDBC driver been tested with CloudWatch to ensure that CloudWatch telemetry is supported?

Yes. There was a screen shot that Affonso showed - but not sure where it is right now.

Copy link
Contributor

@andiemontoyeah andiemontoyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM!

@mitchell-elholm
Copy link
Contributor

LGTM!

@birschick-bq birschick-bq merged commit 74fb1e1 into develop Dec 14, 2022
@birschick-bq birschick-bq deleted the affonsov/add-mongodriverinformation branch December 14, 2022 23:54
normanj-bitquill pushed a commit to normanj-bitquill/amazon-documentdb-jdbc-driver that referenced this pull request Dec 27, 2022
* Bump commons-text from 1.9 to 1.10.0

Bumps commons-text from 1.9 to 1.10.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump com.github.spotbugs from 5.0.10 to 5.0.13

Bumps com.github.spotbugs from 5.0.10 to 5.0.13.

---
updated-dependencies:
- dependency-name: com.github.spotbugs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump mockito-core from 4.8.0 to 4.8.1

Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.8.0...v4.8.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Commit Code Coverage Badge

* Bump sslcontext-kickstart from 7.4.7 to 7.4.8

Bumps [sslcontext-kickstart](https://github.com/Hakky54/sslcontext-kickstart) from 7.4.7 to 7.4.8.
- [Release notes](https://github.com/Hakky54/sslcontext-kickstart/releases)
- [Changelog](https://github.com/Hakky54/sslcontext-kickstart/blob/master/CHANGELOG.md)
- [Commits](Hakky54/sslcontext-kickstart@v7.4.7...v7.4.8)

---
updated-dependencies:
- dependency-name: io.github.hakky54:sslcontext-kickstart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump checkstyle from 10.3.4 to 10.4

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.3.4 to 10.4.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.3.4...checkstyle-10.4)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Revert "Bump checkstyle from 10.3.4 to 10.4"

This reverts commit b4b048d.

* Adding mongo driver information

* fixing build.gradle

* adding missing class

* Revert "adding missing class"

This reverts commit 5a53d21.

* adding missing class

* adding license

* fixing check style

* adding final test fixture

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1032] Driver / Application information for CloudWatch. Simplify application and version handling.

* Commit Code Coverage Badge

* [AD-1032] Refactored creating the MongoClient for cleaner use.

* [AD-1032] Fixed style issues.

* [AD-1032] Fixed style issues aws#2.

* [AD-1032] Fixed style issues aws#3.

* Commit Code Coverage Badge

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
Co-authored-by: birschick-bq <birschick-bq@users.noreply.github.com>
Co-authored-by: affonsoBQ <affonsoBQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants