Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AD-400] Increase code coverage in calcite adapter #228

Merged

Conversation

andiemontoyeah
Copy link
Contributor

Summary

  • Increase code coverage by removing unused code and adding tests

Description

  • Removed passing around mongo client and mongo cursor since we never execute the query on the adapter side
  • Removed field getter work in enumerator since we never execute query on the adapter side
  • Removed unused methods
  • Removed the SchemaReader, SchemaWriter and SchemaStoreFactory
  • Removed FileSchemaReader and Writer
  • Added additional tests for DocumentDbSchema and DocumentDbMetadataColumn

Related Issue

https://bitquill.atlassian.net/browse/AD-400

Additional Reviewers

@affonsoBQ
@andiem-bq
@alexey-temnikov
@birschick-bq

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@andiemontoyeah andiemontoyeah marked this pull request as ready for review December 15, 2021 17:23
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

  45 files    45 suites   10m 22s ⏱️
606 tests 606 ✔️ 0 💤 0 ❌
614 runs  614 ✔️ 0 💤 0 ❌

Results for commit 62e448c.

@andiemontoyeah andiemontoyeah merged commit c41d853 into develop Dec 28, 2021
@andiemontoyeah andiemontoyeah deleted the andiem/AD-400/increase_code_coverage_in_calcite_adapter branch February 1, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants