Add cumulative to delta conversion for JMX metrics. #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisguo
approved these changes
Jul 30, 2024
musa-asad
approved these changes
Jul 30, 2024
JayPolanco
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There are quite a few JMX metrics (e.g.
kafka.message.count,kafka.network.io, etc.) that are reported as cumulative sums/histograms. In CloudWatch, these metrics are more useful as deltas, which will allow for easier alarming and anomaly detection. We've made the decision to convert all applicable JMX metrics to deltas.Description of changes
Adds the cumulativetodelta processor to all JMX pipelines.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added unit tests.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint