Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate code in demos/browser/server.js file #2899

Closed
wants to merge 2 commits into from

Conversation

dahae0320
Copy link

Issue #: N/A

Description of changes:
Delete duplicate else-if statements in demo app, server.js file. (pathname: end)

  • Duplicate code locations: demos/browser/server.js
    • lines 209 to 214, lines 311 to 315

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
No.

Checklist:

  1. Have you successfully run npm run build:release locally?
    y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Delete duplicate else-if statements in `server` functions (pathname: end)
@dahae0320 dahae0320 requested a review from a team as a code owner May 30, 2024 08:17
@hensmi-amazon
Copy link
Contributor

unfortunately our integration tests do not work with external forks. I will move it to a remote branch when i get a chance

@dahae0320
Copy link
Author

unfortunately our integration tests do not work with external forks. I will move it to a remote branch when i get a chance

Oh... I'd really appreciate it if you could move it to a remote branch. Thank you so much your comment!

@hensmi-amazon
Copy link
Contributor

Opened #2903 because github doesn't seem to allow me to change the remote branch here.

@dahae0320
Copy link
Author

Thanks :)

@dahae0320 dahae0320 deleted the patch-1 branch June 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants