Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Image Handler Lambda Function - Timeout following API Gateway #380

Conversation

fvsnippets
Copy link

Backend Image Handler Lambda Function construct (CDK) has a timeout of timeout: Duration.minutes(15).
It makes no sense to continue executing the lambda after 29 seconds since Api Gateway on front will have replied to CloudFront with a 504 status code (Gateway Timeout).
Notice: read about Api Gateway integrations limits with Lambda.

Issue #, if available: #379

Description of changes:
Backend Image Handler Lambda Function construct (CDK) configured with timeout: Duration.seconds(29).

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fisenkodv
Copy link
Contributor

@fvsnippets thank you for your contribution. We will look into it and add it to our backlog.

@github-actions
Copy link

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the Stale label Dec 21, 2022
@fvsnippets
Copy link
Author

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

Keeping it open.

@github-actions github-actions bot removed the Stale label Dec 22, 2022
@github-actions
Copy link

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

…ge Handler Lambda Function since Api Gateway on front has that limitation.
@fvsnippets fvsnippets force-pushed the backend-image-handler-lambda-function-timeout branch from 3e8413c to 9bd9e18 Compare October 8, 2023 03:34
@fvsnippets
Copy link
Author

Updated with current main branch (using rebase). Conflicts were resolved.

@simonkrol
Copy link
Member

Hi @fvsnippets,

This change has been included in v6.2.4 of SIH. Our internal processes have us merge the code manually, so you won't see this PR get merged, but your profile has been included in the external contributors list at the bottom of the readme.

Thanks for your contributions :)
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants